Selected AOIs do not persist when E&A URL is shared

US-GHG-Center / veda-config-ghg

Veda config for GHG

https://ghg-demo.netlify.app

Other

3 stars 14 forks source link

Selected AOIs do not persist when E&A URL is shared #406

Open sanzog03 opened 2 weeks ago

sanzog03 commented 2 weeks ago

Generally, In exploration the "delete all areas" button work when there are multiple polygons, i.e. without selecting any polygons. However, for the link shared by @Paridhi, the "delete all areas" button doesnot work unless we click on the polygon. I could find this behaviour only on this link, so might be something specific about that ploygon.

sanzog03 commented 2 weeks ago

Note: I tried the link in production - with staging removed from the url, and the issue was there for the same polygon in production as well. So, this bug was there from before.

slesaad commented 2 weeks ago

cc @aboydnw

aboydnw commented 2 weeks ago

Somehow, in the link you provided, the dashboard thinks that an area is selected. You can see that in the URL parameter: &selectedForEditing=true

and you can see it in the UI:

I have tried to recreate this condition and have been unsuccessful. Any time I select, delete, create, or perform another action then the selected state seems to be correct. @sanzog03 or @paridhi-parajuli are either of you able to recreate this condition? That would lead us to the bug.

aboydnw commented 2 weeks ago

Ah, wait, as soon as I sent that I had a suspicion and can now reliably reproduce the issue. See below

Steps to Reproduce:

Go to exploration and analysis page
Create any number of AOIs
Select at least one of those AOIs
Copy the URL to send to somebody else
In a new window/tab, paste the URL
Notice that no AOIs are selected, although the URL and part of the UI believes that to be true (the highlighted part in my last comment)

User Workaround:

Clicking on any of the AOIs will select that AOI and "reset" the UI to function properly
Clicking anywhere else on the map will unselect the AOIs and "reset" the UI to function properly

Proposed Action

Since we know the workaround and the severity of the issue is not very high, I propose we place this ticket in the backlog, potentially for next PI.

sanzog03 commented 2 weeks ago

@aboydnw We aren't exactly sure how we came to this bug, however, the steps to reproduce the bug seems like something we might have done. I agree that this is not a severe issue as there is a workaround to this, so placing it in the backlog seems good. Also @paridhi-parajuli if you at some time remember how you came to this bug or be sure that these steps were what you did, update that in this ticket.

aboydnw commented 2 weeks ago