USA-RedDragon / jagex-launcher-linux-flatpak

Play RuneScape with the Jagex Launcher - in Flatpak form!
Other
123 stars 0 forks source link

Install script not parsing out correct field for nvidia driver version #116

Open tired-runner opened 2 weeks ago

tired-runner commented 2 weeks ago

This is an issue with (choose one or more):

Describe the bug A clear and concise description of what the bug is. When installing, the NVIDIA_VERSION variable gets set to "for" instead of the version

To Reproduce Steps to reproduce the behavior:

  1. use the installation script from the readme with open nvidia kernel module (I don't have a system with the non open kernel module to test with, but I assume the issue is they added more words to the first line of the /proc/driver/nvidia/version output)

Expected behavior A clear and concise description of what you expected to happen.

Should get the version field and install the dependency

Logs

Flatpak Log
```text LOGS GO HERE ```

Screenshots If applicable, add screenshots to help explain your problem. Screenshot from 2024-10-19 11-08-47

System

Additional context Add any other context about the problem here.

On my machine at least, this would work to extract the version, but I am not so familiar with bash best practices cat /proc/driver/nvidia/version | head -n 1 | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+' | sed 's/\./-/g'

USA-RedDragon commented 2 weeks ago

Could you send the contents of cat /proc/driver/nvidia/version so I can see what changed about the output? Thanks

tired-runner commented 2 weeks ago

Here's the output: NVRM version: NVIDIA UNIX Open Kernel Module for x86_64 560.35.03 Release Build (dvs-builder@U16-I1-N07-12-3) Fri Aug 16 21:42:42 UTC 2024 GCC version: gcc version 14.2.1 20240912 (Red Hat 14.2.1-3) (GCC)