search

USACE-WaterManagement / repgen5

A program for creating simple fixed format text reports.
MIT License
1 stars 3 forks source link

Should we be using cwms-python? #24

Open krowvin opened 6 months ago

krowvin commented 6 months ago

I was working on the levels and adding those. (We have something custom, but I'm thinking I'll create an issue and try to submit something for this)

While they do not exist in cwms-python yet to my knowledge, they will eventually.

It looks like we are using URL lib under the hood and have full control over the responses for Timeseries.

In my opinion, the cmws-python library would add more dependencies to this project. But it is a consistent way to fetch the data against the API.

My vote would be no, but I'm curious if everyone else feels that way

MikeNeilson commented 6 months ago

It's arguable, but cwms-python didn't exist at the time of writing this initially.