search

USACE / cwms-data-api

Corps Water Management System RESTful Data Service
MIT License
13 stars 14 forks source link

Add delete types to timeseries endpoint #267

Closed adamkorynta closed 1 year ago

adamkorynta commented 2 years ago

Parameters for "Delete Data", "Delete Key", and "Delete All" are used throughout CWMS.

rma-rripken commented 1 year ago

I tried running the integration tests locally because I was going to add some additional tests but I'm having issues getting them to run consistently and in a reasonable amount of time. I deleted the docker volume and had it build from scratch and after a long wait the IT suite appears to have worked but then when I run it a second time some of the pre-existing tests failed. When I tried to re-run a specific IT it just sort of hung. I'm not going to look into it too hard atm b/c I'm thinking that the authorization stuff is going to change again pretty soon.

MikeNeilson commented 1 year ago

Yeah, don't worry about that. I'm working on that this week. I'm not entirely sure what's going on but I'm seeing the same behavior in the tests. Though I wasn't too concerned until you just mentioned having the same concern. I'll pivot my focus a bit and see if I can back port quickly; otherwise I'm at the point of actually doing the tests for the auth manager changes and they'll go in with that.