search

USACE / cwms-data-api

Corps Water Management System RESTful Data Service
MIT License
11 stars 14 forks source link

Release fixes 20240625 #744

Closed MikeNeilson closed 3 months ago

MikeNeilson commented 3 months ago

Okay, so I gave some bad advice earlier, when using CwmsDatabaseContainer::connection use the CwmsDataApiSetupCallback.getWebUser() as the connection user.

Also when using an arbitrary office, make sure within users.sql the &webuser has full permissions in that office to handle all that.

Otherwise most of this was just super nitpicky details and timings about when data was or wasn't deleted.

The most annoying thing was the Office XML, FYI FasterXML's jackson-databind-xml does not and cannot correctly serialize a Collection directly using anything other than the Collection name as the root and "item" as the sub elements. Hence the XMLv2Office class. Spent way to long on that and probably should've just had it fail or something.

NOTE: tested against schema 24.05.24-RC03, the locations can't be stored correctly from the newer data sets without the additional nation id fix Adam made.

MikeNeilson commented 3 months ago

For reference: @rma-bryson @rma-psmorris @zack-rma

MikeNeilson commented 3 months ago

The eclipse and idea plugs were added in an attempt to make the IDE integration work better. Unfortunately I think using "cwms-data-api" for one of the sub projects is at least breaking eclipse/vscode. @krowvin got the wonkiest result and I started having issues as well after that change.

I need to do some manual testing first tomorrow, but I'm hoping to experiment with that in a fresh environment tomorrow and made rename the subproject folder so just api if required.

MikeNeilson commented 3 months ago

Would you believe in fixing the catalog I broke the catalog? ... column names are a pain.