search

USACE / go-consequences

A lightweight consequences computational engine written in Go
MIT License
14 stars 11 forks source link

wip #113 #114

Closed HenryGeorgist closed 1 year ago

HenryGeorgist commented 1 year ago

work in progress

rnugent3 commented 1 year ago

The changes make sense to me. I reviewed the results file, too. Results make sense. My only suggestion would be to think about a more useful way to report the hazard data - in the current format, it would be really hard to post-process.

HenryGeorgist commented 1 year ago

The changes make sense to me. I reviewed the results file, too. Results make sense. My only suggestion would be to think about a more useful way to report the hazard data - in the current format, it would be really hard to post-process.

it is a json blob, so it is pretty easily serializable - the reason i do that is that some hazards have multiple variables (e.g. wave heights, or velocities) I am trying to make it more flexible for hazards to be treated abstractly in the results writing so that results writing doesnt confine the capability of the software - im open to ideas if you have them