search

USACE / go-consequences

A lightweight consequences computational engine written in Go
MIT License
14 stars 11 forks source link

Erosion #87

Closed HenryGeorgist closed 2 years ago

HenryGeorgist commented 2 years ago

staging as a pr so i can monitor more closely and review more easily

HenryGeorgist commented 2 years ago

it seems the test is failing because the resource of the json file is not local to the build. we can either simplify the test to something we define in the testing suite or we can add the resource.

trietmnj commented 2 years ago

Looking good now

trietmnj commented 2 years ago

Do you want to pull into master already? There's no logic to adapt the new DamageFunction struct to the existing DamageFunctionFamily that's directly consumed yet.

HenryGeorgist commented 2 years ago

no i just wanted to have a place to review the code as you work on it. This way i get notifications and can more easily review than just mining commits.

HenryGeorgist commented 2 years ago

i think this is ready to merge. The only thing that could be done before merge is to update the erosion_trial6.json file so that it unmarshals properly