search

USACE / groundwork

React Components for USACE Applications
https://usace.github.io/groundwork
4 stars 0 forks source link

scrub uses of `gw-` in code examples #27

Closed willbreitkreutz closed 2 months ago

willbreitkreutz commented 2 months ago

I think I got all of them, and there were a few places where the gw- got snuck into the wrong spot on some other classes, guess my regex wasn't perfect... 😢

willbreitkreutz commented 2 months ago

I added a rule that requires all pull requests to main be reviewed by someone other than the person submitting it, if it starts to get in the way we can pull it but wanted to try it out.

willbreitkreutz commented 2 months ago

Dang regex went a little crazy, thanks for catching those @jbkolze

jbkolze commented 2 months ago

And just for workflow consistency purposes... Once approved, want to have the reviewer merge or leave it to the author?

willbreitkreutz commented 2 months ago

That's a good question... with a small group i don't really care, but if we see contributions from others then probably a core of "merge doers"