search

USACE / groundwork

React Components for USACE Applications
https://usace.github.io/groundwork
4 stars 0 forks source link

fix linting and make some corrections #35

Closed adamscarberry closed 2 months ago

adamscarberry commented 2 months ago

There's going to be some extra changed due to prettier differences (I use single quotes). If we want to decide on common formatting that includes double quotes I can fix this before merging.

https://github.com/USACE/groundwork/issues/34

jbkolze commented 2 months ago

@adamscarberry , my main issue was actually with the .eslintrc.cjs file. Mind if I push a commit containing some edits there to this or should I do it as a separate PR?

adamscarberry commented 2 months ago

@jbkolze Yea go ahead and include since it's linting related. I would like to also include eslint-plugin-jsx-a11y in our devDependencies and configure in eslintrc.cjs, but didn't want to throw too much at once.

example: https://github.com/USACE/a2w-ui/blob/main/.eslintrc.cjs

adamscarberry commented 2 months ago

Eventually we should setup a workflow for linting test on PR creation and fails are unable to merge.

jbkolze commented 2 months ago

@adamscarberry I threw in what I had in mind as a starting point. Basically standard defaults with a couple tweaks to not drown in error hell in existing files (based on what I checked, at least). Agree with jsx-a11y -- will let you handle that part since I don't have a lot of experience with it.

Feel free to adjust as needed / preferred.

jbkolze commented 2 months ago

Just for clarification -- I think the typescript linting stuff was a remnant from the initial groundwork build using styled-components and typescript. Typescript was completely ripped out when the shift to tailwind happened. I think the .eslint was just the last piece that got missed.

adamscarberry commented 2 months ago

I think I'm done with changes on this one.