search

USACE / groundwork

React Components for USACE Applications
https://usace.github.io/groundwork
4 stars 0 forks source link

Docs internal links break when opened in new tab #37

Open jbkolze opened 2 months ago

jbkolze commented 2 months ago

Internal links within the groundwork documentation don't work correctly when opened with a middle-click or "Open in new tab". Results are different depending on whether you're running locally or using the github pages production site:

Seems like this might be related to the hash-router implementation but haven't investigated to know for sure.

willbreitkreutz commented 2 months ago

Hmm, yup, it's because the paths in the links are all relative and we're dynamically adding the /groundwork. We'll need to take a look at the routing stuff and figure out how to handle that.

willbreitkreutz commented 1 month ago

Ugh, the only solution I can come up with so far is to add /groundwork/#/docs... to anywhere we use a href in the docs site. Either we do it for all of them, or we tie in to issue #30 and just abstract out a <Link /> component that does it for us... not sure though