search

USACE / groundwork

React Components for USACE Applications
https://usace.github.io/groundwork
4 stars 0 forks source link

Header Nav Max Width instead of fluid #46

Closed adamscarberry closed 5 months ago

adamscarberry commented 5 months ago

I'm working on porting A2W to use groundwork.

I need the header nav to have a max width and not stretch across the entire width (especially on large screens).

The USACE HQ site is also fixed with a max width.

Example shown below:

image

I have started this modification to groundwork, but struggling to get all the details working correctly. Before continuing I wanted to get consensus if this sounds ok or if this is the wrong direction.

cc @willbreitkreutz

willbreitkreutz commented 5 months ago

I think add a fluid-nav prop to the SiteWrapper to make it opt-in for full width similar to Container

willbreitkreutz commented 5 months ago

but yeah, default it to a constrained with is fine, do you want me to take a look at how?

@adamscarberry

adamscarberry commented 5 months ago

@willbreitkreutz If you think you have a quick way to make the adjustments, go for it. It seemed more complicated when I got into it. Now that I think about it, the footer will probably also need the same treatment.

willbreitkreutz commented 5 months ago

@adamscarberry i'll give it a go

adamscarberry commented 5 months ago

@willbreitkreutz If you get into it and wish you hadn't :-). I can push what I have as a branch. It's just a bit messy at the moment.

willbreitkreutz commented 5 months ago

@adamscarberry yeah, not as straightforward as I thought it would be, got it working for the header, need to modify the footer next

willbreitkreutz commented 5 months ago

Woo, footer was actually easy since I was already using the Container element in there...