search

USACE / groundwork

React Components for USACE Applications
https://usace.github.io/groundwork
4 stars 0 forks source link

46 header nav max width instead of fluid #48

Closed willbreitkreutz closed 2 months ago

willbreitkreutz commented 2 months ago

Make it so you can pass a fluidNav prop to the SiteWrapper component. If fluid, then full width, otherwise the default is the constrained width of the Container element (1140px I believe)

adamscarberry commented 2 months ago

The banner at the top will need to have a max width too.

image

Do you prefer specifying the max width in pixels vs gw-max-w-screen-2xl which equals 1536px. https://tailwindcss.com/docs/max-width

willbreitkreutz commented 2 months ago

@adamscarberry I'll give the banner a shot, I did it in px because i copied it from somewhere else....

adamscarberry commented 2 months ago

@willbreitkreutz ok. If you have no objections, I would like to use gw-max-w-screen-2xl for the limited width and w-full for the fluid.

For reference w-full = width: 100%; where as w-screen = width: 100vw;. I'm not sure which is better at the moment.

willbreitkreutz commented 2 months ago

w-full will honor any sizes set above it in the tree, w-screen will look at the actual viewport size...

I'll update the classes to use the tailwind classes

willbreitkreutz commented 2 months ago

@adamscarberry ready for review