USACE / instrumentation

Instrumentation project issue tracking and project planning
MIT License
4 stars 1 forks source link

[BUG REPORT]: UI will not save updated Station and Offset #150

Closed ScottMassa closed 5 months ago

ScottMassa commented 6 months ago

Describe the bug

User tries to modify the station and offset, updated values are seen, but not saved.

Steps To Reproduce

Edit instrument, modify station and offset, click save, the UI shows the new values, but it is not saved.

Expected behavior

new values are expected to be saved.

Actual behavior

Not saved, API error. ( see screenshot below)

Screenshots

image

Desktop (please complete the following information):

Additional context

User also mentioned similar when adding constants or timeseries to an instrument.

ScottMassa commented 6 months ago

Also similar behavior when adding instruments to plot groups. i try to add an instrument and after saving it doesn't appear in the plot groups. no put error in MS Edge inspector this time.

dennisgsmith commented 6 months ago

@KevinJJackson The PUT payload sent to /projects/:project_id/instruments/:instrument_id should include type_id field, instead it's null.

I'll look into the instrument group issue separately and report back.

dennisgsmith commented 6 months ago

Also similar behavior when adding instruments to plot groups. i try to add an instrument and after saving it doesn't appear in the plot groups. no put error in MS Edge inspector this time.

This was a separate bug, fix pushed to develop in https://github.com/USACE/instrumentation-api/pull/203

Stable fix is scheduled for next release.

dennisgsmith commented 5 months ago

Fixed deployed in https://github.com/USACE/instrumentation-api/pull/210