search

USACE / instrumentation

Instrumentation project issue tracking and project planning
MIT License
4 stars 1 forks source link

Filter Parameter List By Instrument in Formula Editor #164

Open ScottMassa opened 4 months ago

ScottMassa commented 4 months ago

Describe the bug

The Formula Editor now shows instrument timeseries name as requested instead of slug. It also shows all timeseries per project. Problem is its unclear which timesieries is which. The name "riser" is shown multiple times for example.

Steps To Reproduce

  1. Go to instrument screen
  2. Click on formula editor
  3. Scroll down to see multiple entries

Expected behavior

Available parameters would be instrument and timeseries. Maybe the instrument shown on the page would be listed first, then other options (maybe searchable) would be below.

Actual behavior

Large list of parameters, not sure which is which.

Screenshots

image

Desktop (please complete the following information):

dennisgsmith commented 4 months ago

@ScottMassa Thank you for filing a bug report. @KevinJJackson and I are assessing this issue and working towards a fix.

dennisgsmith commented 4 months ago

Hi @ScottMassa -- after discussing this with @KevinJJackson, it seems like the most straightforward solution would be to simply use the entire variable in the lefthand list, in order to more easily differentiate which instrument the parameter belongs to, while still allowing cross-instrument formulas to exist. The proposed change would change the list on the left as follows:

battery   -> test-instrument-1.battery
battery-2 -> test-instrument-2.battery-2
battery-3 -> test-instrument-3.battery-3

This will reflect exactly as they appear in the formula editor after double-clicking the parameter. Feel free to provide any feedback you have on this solution.

ScottMassa commented 4 months ago

I think this looks good. Is there any way show only the instrument, then click a button to expand to all the others? Some projects may show several hundred timeseries to choose from.

KevinJJackson commented 4 months ago

@ScottMassa - Merged the initial change to be able to visually differentiate the timeseries. We will come back to this issue after our main priorities are completed and adjust this further.