Wrong Page Numbers on Instrument Browser

USACE / instrumentation

Instrumentation project issue tracking and project planning

MIT License

5 stars 1 forks source link

Wrong Page Numbers on Instrument Browser #34

Closed lucasb16-exe closed 3 years ago

lucasb16-exe commented 3 years ago

PageIssue

Issue appears limited to projects with greater than 3 pages worth of instruments, repeats some page numbers and does not display others, will update issue with further investigation

KevinJJackson commented 3 years ago

Can you provide browser and OS that you are using?

I'm running: MacOS 10.15.7 Firefox 84.0.2

and I'm not seeing this issue, looking at Herbert Hoover Dike locally:

KevinJJackson commented 3 years ago

Was able to partially reproduce this by changing the items per pages dropdown value, however:

lucasb16-exe commented 3 years ago

Issue was reported by onsite park ranger at Salamonie, I'm also seeing this on production running with 10 instruments per page. I'll test locally and report back as well.

Google Chrome Version 88.0.4324.96 - 64 bit Windows 10 Enterprise Version 18363.1139

KevinJJackson commented 3 years ago

Think I found the cause, but if you could run this locally as well just to make sure. Looks like a typo when creating the inner pages of the pagination component: https://github.com/USACE/instrumentation-ui/blob/develop/src/app-components/pager.js#L53

instead of i + i, it should be i + 1

lucasb16-exe commented 3 years ago

Closing with merge, thanks Kevin