In s3_objects, the prefix param takes on a default value of "ddc/uat". This made sense at the time, but as we start using PEPFAR's s3 buckets (prefix is usaid/ only when we are in the S3_WRITE folder and NULL in S3_READ) and possibly use s3 for DDC, I think the default should be changed back to NULL
In
s3_objects, theprefixparam takes on a default value of"ddc/uat". This made sense at the time, but as we start using PEPFAR's s3 buckets (prefixisusaid/only when we are in theS3_WRITEfolder andNULLinS3_READ) and possibly use s3 for DDC, I think the default should be changed back toNULLhttps://github.com/USAID-OHA-SI/grabr/blob/76726e9fcdfc6acdecc34d5f1b596bf5c950b2ac/R/import_s3objects.R#L50-L56
Note that the
prefixis by default""ins3_upload. I would argue these should all the same https://github.com/USAID-OHA-SI/grabr/blob/76726e9fcdfc6acdecc34d5f1b596bf5c950b2ac/R/import_s3objects.R#L451-L456