USAID-OHA-SI / tameDP

Import and munge data from PEPFAR Target Setting Tools
https://usaid-oha-si.github.io/tameDP/
Other
1 stars 3 forks source link

Missing mech info with PSNUxIM #72

Closed achafetz closed 8 months ago

achafetz commented 8 months ago

@lbaraki: Wanted to flag another issue I was having. Not an error but the map_names parameter isn't working when set to TRUE for the PSNUxIM file. I'm not seeing any mechanism specific information being imported in from DATIM.

achafetz commented 8 months ago

The issue is a result of changes made to order_vars. In attempt to clean up the code to avoid duplication, I forgot to include the mechanism information back into the v_order and so it was stripping out the the mech info on export (and didn;t have a PSNUxIM to test at the time).

https://github.com/USAID-OHA-SI/tameDP/blob/34ef52dae782332b8a173dc89d5044293c82389f/R/order_vars.R#L17-L29