search

USArmy-Corps-of-Engineers-RMC / Numerics

Numerics is a free and open-source library for .NET developed by USACE-RMC, providing a comprehensive set of methods and algorithms for numerical computations and statistical analysis.
Other
21 stars 2 forks source link

BoxCox - Using LogLikelihood in FitLambda #63

Closed sadie-niblett closed 3 months ago

sadie-niblett commented 3 months ago

In the BoxCox.cs there was a LogLikelihood() method with no current references. In the FitLamba() method right above, it seemed to be using the log likelihood as the function to fit lambda to. I'm assuming the LogLikelihood() function was written to be used in FitLamba() to make it easier to read and break down. I wrote another version that uses the LogLikelihood() function instead of rewriting the same code. I've left the original method commented out right above it.

HadenSmith commented 3 months ago

Great fix! I deleted the old code