search

USArmy-Corps-of-Engineers-RMC / Numerics

Numerics is a free and open-source library for .NET developed by USACE-RMC, providing a comprehensive set of methods and algorithms for numerical computations and statistical analysis.
Other
18 stars 2 forks source link

Test_GoodnessOfFit - Comment in Test_ChiSqauredTest #70

Closed sadie-niblett closed 1 month ago

sadie-niblett commented 1 month ago

In the Test_ChiSqauredTest() the XML comment says "No code implements this test in this same manner. Results from R are close though" with the test written below and the Assert.AreEqual() commented out as it fails. I just want to double check that this was good enough for the test, and nothing more needs to be done here.

HadenSmith commented 1 month ago

I found a similar implementation in EnvStats and added a formal test. My implementation was correct. The issue was the histogram bin points. In this package you can provide a list of bins for an apples-to-apples test.