search

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.44k stars 1.14k forks source link

Removing print statement, appears to be leftover from debugging module #118

Closed amm3 closed 3 years ago

amm3 commented 3 years ago

This PR requests rolls up two commits: 1) Print statement resulted in header dictionary being written to stdout, outside of output module control. 2) I've found it useful to have more verbose request and response headers in the JSON output. To avoid name-space conflicts, I like to have these as nested objects in the dictionary. In this PR I'm only adding the response headers as response_headers, whereas the request headers are already merged into the outer kwarg dictionary.... I could easily see rolling these up similarly under a request_headers label.

dev195 commented 3 years ago

This looks good to me. And I agree with making the request_header another dictionary. The consistency is preferable.

If you want to make the change and add it to this pull request, I can accept it.

amm3 commented 3 years ago

Sounds good... just updated.

By the way, there are some really good design considerations in this release! I can tell a lot of hard work went into it. Cudos!