USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.44k stars 1.14k forks source link

Multiprocessing AttributeError bug #129

Closed dev195 closed 3 years ago

dev195 commented 3 years ago

A bug was found in decode.py that prevents the --parallel flag from functioning properly. Below is the exception seen:

Traceback (most recent call last):
  File "/home/user/lib/python3.6/multiprocessing/process.py", line 249, in _bootstrap
    self.run()
  File "/home/user/lib/python3.6/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "/home/user/Dshell/build/lib/dshell/decode.py", line 430, in process_files
    input0 = inputs.pop(0)
AttributeError: 'str' object has no attribute 'pop'

To fix, add a comma after [i] in line 386: multiprocessing.Process(target=process_files, args=([i],), kwargs=kwargs)

We will permanently correct this bug after finalizing our review of pull request #120