search

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.44k stars 1.14k forks source link

Handle plugin specified diverse directions for non connection/blob objects in colorized/html output #130

Closed amm3 closed 3 years ago

amm3 commented 3 years ago

In the previous version of colorout, decoders would make multiple calls to write(), specifying direction on each call. This allowed for output that indicated the directionality of back-and-forth communications. Version three changes the behavior slightly, having the output module format a connection/packet header and then iterate through multiple related elements. This works fine for blobs which have their directionality specified internally, but there is currently no mechanism for the decoder plugin to specify the direction.

This is just one potential approach to a solution. I'm quite open to discussion. But because the output module already passes tuples of (data, direction) internally this seemed to make sense.

dev195 commented 3 years ago

This looks good. I'll merge it. Thank you for the support!