search

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.45k stars 1.14k forks source link

Attempt to keep line length legible and below 80 characters with small e... #14

Closed eshim closed 9 years ago

eshim commented 9 years ago

...xceptions.

matt-ward commented 9 years ago

I think they're okay on the comments...come on.

RyPeck commented 9 years ago

For PEP8 technically docstrings line length is suppose to be 72 characters. All depends on how... orderly you want to be. Up to the project maintainers!

matt-ward commented 9 years ago

I don't disagree with that, I was more implying that the quick pull req is lacking in substantive quality and more an effort to get your public contribution graph colored in.

eshim commented 9 years ago

Ah, I'll see what I can do about the docstring lengths.

wglodek commented 9 years ago

@eshim We agree with @matt-ward that the pull request does not have enough substance.

eshim commented 9 years ago

I understand, I'll approach this again when have more time to cover formatting.

On Tue, Feb 10, 2015 at 7:23 AM, William Glodek notifications@github.com wrote:

@eshim https://github.com/eshim We agree with @matt-ward https://github.com/matt-ward that the pull request does not have enough substance.

— Reply to this email directly or view it on GitHub https://github.com/USArmyResearchLab/Dshell/pull/14#issuecomment-73697871 .