search

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.45k stars 1.14k forks source link

Bug in large-flows.py decoder #51

Closed slinkard closed 3 years ago

slinkard commented 9 years ago

The large-flows.py decoder appears to have a bug in the code in line 24. The decoder is designed for flows 1MB or larger. This would 1048576 bytes. Line 24 incorrectly omits the last digit:

self.min = 104857 * self.size

should be

self.min = 1048576 * self.size

wglodek commented 9 years ago

@slinkard Thanks! Fixed in 80ad7a3df023c907a7407448ef60c02f375e426f. The developer responsible for this bug has been promoted to middle management and should no longer be a problem.

dek443 commented 3 years ago

The Python 2 version of Dshell is now deprecated and frozen as Release v2.4.10. We are closing all Pull Requests and Issues associated with that version, as Dshell development has shifted to the current version for Python 3. Thank you for your support.