Remove redundant file open mode

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.

Other

5.45k stars 1.14k forks source link

Closed frewsxcv closed 9 years ago

frewsxcv commented 9 years ago

The default is 'r', these are redundant

RyPeck commented 9 years ago

This is a seemingly insignificant change - my only thought is from PEP20 -

Explicit is better than implicit. https://www.python.org/dev/peps/pep-0020/

frewsxcv commented 9 years ago

This is a seemingly insignificant change

If cleaning up code is forbidden in this repo, I'm sorry for wasting your time

Explicit is better than implicit

Why not open('filename', 'r', -1) and explicitly specify you want to use the system default for buffering?