search

USArmyResearchLab / Dshell

Dshell is a network forensic analysis framework.
Other
5.45k stars 1.14k forks source link

TCP handshake and port reuse fix #91

Closed dc3-tsd closed 7 years ago

dc3-tsd commented 8 years ago

Fix to prevent reused ports from the previous TCP connection.

TCP handshaking fix for SYN flag.

dev195 commented 8 years ago

Alright, I see where you're going with this.

My only issue is that the clientclosed and serverclosed flags are attached to the TCPDecoder object. I worry this might lead to a race condition allowing one connection to interfere with and prematurely close another separate connection.

I was messing around with it a little and will post an update that should act the same as before. In this case, those two flags are attached to the Connection object. Give it a try when you get the chance.

dc3-tsd commented 7 years ago

We tested this locally and ran into some issues. Another pull request is being submitted that replaces this one based on your feedback.