Fix LGTM CI (by updating bundled PEGTL from 3.2.3 to 3.2.5 for GCC 9.2) - Githubissues

USBGuard / usbguard

USBGuard is a software framework for implementing USB device authorization policies (what kind of USB devices are authorized) as well as method of use policies (how a USB device may interact with the system)

https://usbguard.github.io/

GNU General Public License v2.0

1.1k stars 133 forks source link

Fix LGTM CI (by updating bundled PEGTL from 3.2.3 to 3.2.5 for GCC 9.2) #528

Closed hartwork closed 2 years ago

hartwork commented 2 years ago

The story here is that:

LGTM is using C++ compiler c++ (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008 when probing USBGuard code.
Our PEGTL 3.2.3 turned out to have a compile error issue with GCC 9.2.
LGTM does not inspect submodule updates, so it failed to fail the CI of PR #521.
All that combined broke the LGTM integration on master and causes the red CI crosses that we see today.

For a fix:

(While LGTM also has Clang 9 available, switching the LGTM config to Clang would not fix the compile error at the source.)
Hence I'm updating our bundled PEGTL to upstream 3.2.5 with the GCC 9.2 fixes, extend the LGTM config to be more helpful with similar issues in the future, and make GitHub Actions cover GCC 9.2 explicitly to detect future regressions independent from LGTM.

CC @radosroka

radosroka commented 2 years ago

Looks good.