search

USBGuard / usbguard

USBGuard is a software framework for implementing USB device authorization policies (what kind of USB devices are authorized) as well as method of use policies (how a USB device may interact with the system)
https://usbguard.github.io/
GNU General Public License v2.0
1.1k stars 133 forks source link

include missing <cstdint> #583

Closed kraj closed 1 year ago

kraj commented 1 year ago

gcc 13 moved some includes around and as a result is no longer transitively included [1]. Explicitly include it for uint8_t.

[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

Signed-off-by: Khem Raj raj.khem@gmail.com

hartwork commented 1 year ago

Hello @kraj we already have #582 on that very front but your version seems to be more complete. @Cropi what do you think?

Cropi commented 1 year ago

LGTM! Thanks for the PR.

I just don't understand why github actions have not been executed. Maybe I am missing something.

hartwork commented 1 year ago

LGTM! Thanks for the PR.

I just don't understand why github actions have not been executed. Maybe I am missing something.

@Cropi not sure, I think that may be a GitHub hick-up. They all ran over in my fork at https://github.com/hartwork/usbguard/actions?query=branch%3Agcc-13-ci .

hartwork commented 1 year ago

@Cropi nevermind, mixed up the two PRs, sorry. My CI covers this as a side effect.

Cropi commented 1 year ago

Thank you for the PR. I am closing it as it has been fixed in https://github.com/USBGuard/usbguard/pull/586