USC-NSL / Computational-Agroecology

6 stars 1 forks source link

Adding Water Balance, Chapter 5 #103

Closed oseisenberg closed 4 years ago

ralphchung commented 4 years ago

@FutureVR Besides everything I have mentioned above, it is necessary and convenient to clang-format before you submit your code. If you don't have it, it is easy to install it from package managers (either in Linux or macOS).

We already had the configuration file (which is mainly Google C++ Style) for clang-format. So, just run the following command under the root of this repo.

clang-format -i <your .h or .cc file>
ralphchung commented 4 years ago

@FutureVR BTW, you mentioned once that you would like to have basic tests. Did you include them in this PR?

ralphchung commented 4 years ago

@FutureVR Remember to push fixes to this branch so that I can track your progress. Thanks.

ralphchung commented 4 years ago

Remember to clang-format

ralphchung commented 4 years ago

OK this looks good to me. I am now handing over to @barath.