search

USC-NSL / Computational-Agroecology

6 stars 1 forks source link

Rewrite agent #109

Open pinghaoluo opened 4 years ago

pinghaoluo commented 4 years ago

First rewrite, change agent class to agent-Adaptor

ralphchung commented 4 years ago

@pinghaoluo Always avoid pushing binaries to the repo.

ralphchung commented 4 years ago

Be sure to forcely pull the branch back to your local because I have rebased for you.

pinghaoluo commented 4 years ago

@ralphchung all fixed

pinghaoluo commented 4 years ago
  • git rebase first
  • do clang-format

You said you rebase for me? And I didn't write new code. But I remove a lot of file

ralphchung commented 4 years ago

@pinghaoluo I did, but did you pull force before adding those commits?

pinghaoluo commented 4 years ago

@pinghaoluo I did, but did you pull force before adding those commits?

I did, this PR is for rebase purpose

ralphchung commented 4 years ago

Then redo it because it showed conflict when I reviewed this PR.

pinghaoluo commented 4 years ago

Some error occurred when I tried to build and run unit tests and agent_server (grpc). Please fix that. I've done another rebase for you. Pull the latest branch before you do any further changes.

Fixed

pinghaoluo commented 4 years ago

Did you really check before you claimed "you have fixed"? I cannot even compile the unit test, and you pushed binary file again. Please fix the issues ASAP, or this PR will be closed.

Sorry, since you rebased this branch again. I cloned the entire project and made change on it and I pushed the old files.