search

USC-NSL / Computational-Agroecology

6 stars 1 forks source link

Add change related to Postgres Database Info #60

Closed fxdawnn closed 5 years ago

fxdawnn commented 5 years ago

@ralphchung It seems like the current Plant implementation make it unable to allow other Plant type to happen. So it seems like we're not allow to directly initiate the plant type. I'm not sure what should I do to initiate a new plant type.The plant type test is not running for that reason. All other tests seems fine.

After setting up the postgres database through the connection way shown in the code, we still need to figure out how to keep the private key to access to the database.

All the plant type info in plantEnvironment.csv is in the database now. It contains 2000+ records of different types of plant.

Change data structure of the plant for the database class.

fxdawnn commented 5 years ago

@ralphchung Do you think you can help fix those things when you have time? Those attributes were there before refactor because they're keeping the data from ecocrop.

ralphchung commented 5 years ago

@fxdawnn Of course, I could help you. The problem is that I find there is something we don't have the consensus on some part of this PR. If that is fine to you, that would be good. And could you explain a bit more about what do you expect to see here? You mention "before refactoring", but I was not here and do not quite understand how it should be look like.

ralphchung commented 5 years ago

BTW, you may need to give me the access to the server?

fxdawnn commented 5 years ago

@ralphchung a. I don't really care about if the structure is optional or not as long as it can keep the data from data. Or if it's a reference or not. I chose the method that I thought would not get into a conflict that much. That's being said that the attributes are following those existed in planttype.h before the change.

It'll be great if you just follow whatever rule you want. Remember to keep the function that allows all the attribute to exist tho.

b. 'Before refactor' means the old code base. On which you build the refactor. The old codebase 'Plant type' contains all the info which allows the plant selector to select the plants that reach the requirement.

c. Ask Jane to put your server on the list first. I wouldn't worry about the server connection. Because the data is already inside. And there are enough access for you.to reach out to the database/table in

64 . Follow the instruction and you can perform all the database actions.

You're more than free to acquire this or another server if needed.

ralphchung commented 5 years ago

@fxdawnn New changes have been published. Please take a look.

ralphchung commented 5 years ago

@barath Could you please take a look at this PR?

fxdawnn commented 5 years ago

LGTM, can't approve though bc I opened this.

ralphchung commented 5 years ago

@fxdawnn BTW, from the data source you provided, I noticed there was a property called "soil texture". Should we include this in our model? Even though we already had a soil texture in the soil class, it seems that they are different properties but with an identical name.