search

USC-NSL / Computational-Agroecology

6 stars 1 forks source link

Add Qlearning class #81

Closed pinghaoluo closed 5 years ago

pinghaoluo commented 5 years ago

Fixing style including naming. Q_learning is not tested yet since it is now finish. It is only class with function declaration now.

pinghaoluo commented 5 years ago

@ralphchung

ralphchung commented 5 years ago

So where is the unit testing? Please be careful when you submit anything.

ralphchung commented 5 years ago

@pinghaoluo I edited this PR in two commits, 78b9613885462e45eb664b16877886645676b3e4 and 06bb84c42a528c9409f2bbb0335a8647e33f0a67. Please check if this looks good to you.

Also, you have ruined the Makefile when you did git rebase. Please fix it.

pinghaoluo commented 5 years ago

I checked your update and I think they are fine. @ralphchung

I am not sure what do you mean by ruined the Makefile when you did git rebase. Makefile works fine in Agent_function branch while I tried the one in master brach it shows error: simulators/photon_simulator/model/../stdafx.h:21:10: fatal error: GL/glew.h: No such file or directory

include <GL/glew.h>

ralphchung commented 5 years ago

@pinghaoluo They are the necessary files for the photon simulator. You may take a look at the README to know you have to install some libraries to build them.

pinghaoluo commented 5 years ago

Fixed make file, I think this branch is ready to merge. @ralphchung

ralphchung commented 5 years ago

@pinghaoluo Use "squash and merge" next time.