search

USCCANA / netdiffuseR

netdiffuseR: Analysis of Diffusion and Contagion Processes on Networks
https://USCCANA.github.io/netdiffuseR
Other
85 stars 21 forks source link

Threshold Graph Bugfix #36

Open KristinaMiljkovic opened 1 month ago

KristinaMiljkovic commented 1 month ago

Description

Issue was first identified with incorrect node labeling for graphs in the threshold function. The graphs were being assigned ID numbers based on the order they appeared in the output, not based on their internal ID number.

Solution

Upon debugging the threshold function we were able to determine it does work as intended. Solution to threshold graphing problem was determined to be a result of the as.factor function assigning levels to integers as characters in non numerically sorted ordered. Solution was to remove character casting in the misc.r script.

gvegayon commented 1 month ago

Hey @KristinaMiljkovic, thanks for the PR! But it seems that the tests are not passing.