search

USCbiostats / slurmR

slurmR: A Lightweight Wrapper for Slurm
https://uscbiostats.github.io/slurmR/
Other
58 stars 12 forks source link

[JOSS review] Prefer file.path()? #17

Closed mllg closed 5 years ago

mllg commented 5 years ago

This is a part of the JOSS review outlined in openjournals/joss-reviews#1493.

This is nitpicking, but I'd suggest to use file.path() instead of paste() or paste0(). According to the documentation, file.path() should be faster. Feel free to just close this issue if you disagree or have other reasons to not use file.path().

gvegayon commented 5 years ago

Overall, to build filepaths I use sprintf which is about the same as file.path. I do this in the function snames which is a general wrapper. I do see that I was still using paste in some places. Just changed that (thanks!)