[JOSS review] [bug?] Tempfiles overwritten with 2 job objects

USCbiostats / slurmR

slurmR: A Lightweight Wrapper for Slurm

https://uscbiostats.github.io/slurmR/

Other

58 stars 12 forks source link

[JOSS review] [bug?] Tempfiles overwritten with 2 job objects #9

Open mschubert opened 5 years ago

mschubert commented 5 years ago

This is a part of the JOSS review outlined in https://github.com/openjournals/joss-reviews/issues/1493.

Consider the following:

job1 <- Slurm_EvalQ(sluRm::WhoAmI(), njobs = 1, plan = "submit")
job2 <- Slurm_EvalQ(sluRm::WhoAmI(), njobs = 1, plan = "submit")

Slurm_clean(job1)
Slurm_collect(job2)
# Error: Nothing to retrieve. (see ?status).

I assume this is not intended behaviour.

gvegayon commented 5 years ago

No, it is not the intended behavior. You should get a warning when overwriting a job. I'll address this after the review.