USCbiostats / software-dev

Coding Standards for the USC Biostats group
35 stars 7 forks source link

Wiki links broken #10

Closed pmarjora closed 3 years ago

pmarjora commented 3 years ago

@gvegayon I think the wiki links on the software dev page need to be updated to point to the new wiki

gvegayon commented 3 years ago

Not sure what links are now broken. I just changed the Home of the old wiki, pointing to the new one. Could you provide a couple of examples indicating where the broken links are?

pmarjora commented 3 years ago

for example, on line 53:

Coding Standards

  1. Coding Standards

the link takes me to page which is empty other than itself containing a link to the new wiki. (It takes me here: https://github.com/USCbiostats/software-dev/wiki#coding-standards) Is that by design?

gvegayon commented 3 years ago

No, you are looking at the old wiki. The new wiki is located here: https://github.com/USCbiostats/software-dev/blob/master/wiki#welcome-to-the-software-development-wiki, and the links within that page are all fixed.

If people try to go to the link you posted, it will take them to the "The old wiki has migrated" page, so yes, by design. Other than that, we can't do.

pmarjora commented 3 years ago

When I click on that link it works fine, so the new wiki appears to be fine. But when I go to the USCBiostats github page and click on Software-dev, it takes me to a page on which all the links point to the old wiki. So all the links on the software-dev page appear to point to the old wiki.

gvegayon commented 3 years ago

Could you send me a screenshot of where are you clicking on? George G. Vega Yon, Ph.D. +1 (626) 381 8171 https://ggvy.cl Pronouns https://www.aclunc.org/article/frequently-asked-questions-whats-pronoun: he/him/él

On Mon, Oct 18, 2021 at 12:35 PM Paul Marjoram @.***> wrote:

When I click on that link it works fine, so the new wiki appears to be fine. But when I go to the USCBiostats github page and click on Software-dev, it takes me to a page on which all the links point to the old wiki. So all the links on the software-dev page appear to point to the old wiki.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/USCbiostats/software-dev/issues/10#issuecomment-946100578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2FM4BBFOLDIPASPUPUS3UHRZIRANCNFSM5GHFHCWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

pmarjora commented 3 years ago

First shot shows the web address, second shows the links. It looks to me like the changes you made to the ReadME.Rmd are not showing up in the ReadMe.md file (for me at least).

Screen Capture1.pdf Screen Capture2.pdf

gvegayon commented 3 years ago

Thank you! Now I see the issue. Will update and let you know.

George G. Vega Yon, Ph.D. (from mobile) https://ggvy.cl Pronouns: he/him/él

On Mon, Oct 18, 2021, 12:54 Paul Marjoram @.***> wrote:

First shot shows the web address, second shows the links. It looks to me like the changes you made to the ReadME.Rmd are not showing up in the ReadMe.md file (for me at least).

Screen Capture1.pdf https://github.com/USCbiostats/software-dev/files/7368098/Screen.Capture1.pdf Screen Capture2.pdf https://github.com/USCbiostats/software-dev/files/7368097/Screen.Capture2.pdf

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/USCbiostats/software-dev/issues/10#issuecomment-946114015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2FM5RIV2VXBN4JKWU5HDUHR3P7ANCNFSM5GHFHCWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gvegayon commented 3 years ago

Solved in 20dbed0a86223da9ab204b3345b2a213a69397a6

pmarjora commented 3 years ago

Thanks!