search

USCqserver / OpenQuantumBase.jl

Abstract types and math operations for OpenQuantumTools.jl.
https://uscqserver.github.io/OpenQuantumTools.jl/stable/
MIT License
7 stars 2 forks source link

Replace .EIGS with with an interface function #79

Closed hmunozb closed 2 years ago

hmunozb commented 2 years ago

Example of #78

neversakura commented 2 years ago

The errors seem to be cause by the eigen_decomp function. This function aims to provide flexible interface for non-speed-critical usage. I think we can just replace H.EIGS with haml_eigs. https://github.com/USCqserver/OpenQuantumBase.jl/blob/937a3236f1b9578bc223b21817dec2e7a8512ee2/src/hamiltonian/hamiltonian_base.jl#L41-L70

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (72b69e9) into master (937a323) will decrease coverage by 0.08%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   85.19%   85.10%   -0.09%     
==========================================
  Files          32       32              
  Lines        1425     1437      +12     
==========================================
+ Hits         1214     1223       +9     
- Misses        211      214       +3
Impacted Files Coverage Δ
src/hamiltonian/hamiltonian_base.jl 82.25% <75.00%> (-2.36%) :arrow_down:
src/hamiltonian/sparse_hamiltonian.jl 85.71% <100.00%> (+0.71%) :arrow_up:
src/opensys/diffeq_liouvillian.jl 68.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 937a323...72b69e9. Read the comment docs.