USDA-ARS-NWRC / awsm

Automated Water Supply Model (AWSM) was developed at the USDA Agricultural Research Service. AWSM was designed to streamline the workflow used to forecast the water supply of multiple water basins.
Other
9 stars 2 forks source link

AWSM roadmap #71

Open scotthavens opened 4 years ago

scotthavens commented 4 years ago

AWSM is due for a little TLC and perhaps an overhaul. We've been using it for 3+ years now and have begun to dial in the likes, dislikes and the what were we thinking's. This issue aims to try and capture some of the ideas

Types of runs

Data assimilation

Outputs

Right now there are 3 different ways that AWSM outputs simulation results:

Propose to get rid of the wyhr as this isn't used.

ops and devel folders

The simulations are broken down into the following path format:

<basin>/<ops or devel>/<water year>/<project name>

This can lead to an incredible deep folder structure. Propose to drop the ops and devel split and instead use a descriptive project name or a new basin name like tuolumne_ops or king_devel.

Other features

New package structure

awsm
|____ framework
|     |    config and recipies
|     |    framework.py
|
|____ models
|     |    pysnobal
|     |    streamflow
|
|____ assimilation
|     |    snow depth
|     |    others 
scotthavens commented 4 years ago

Issues to address either as part of above or just because.

scotthavens commented 3 years ago

Add to the documentation:

When using the following options, ensure that the restart period is prior to a storm.

The Marks2017 method will calculate the total storm mass to use in the calculations. If the restart date is during a storm, the total storm mass will not be the same and will result in different results. To test this, change the new snow density model in awsm.tests.restart.test_rme.TestSMRFiPysnobalRestart to marks2017 and the test will fail due to the restart date being within a storm.