search

USDA-ARS-NWRC / awsm

Automated Water Supply Model (AWSM) was developed at the USDA Agricultural Research Service. AWSM was designed to streamline the workflow used to forecast the water supply of multiple water basins.
Other
9 stars 2 forks source link

AWSM daily running 1 more hour than needed #87

Closed scotthavens closed 3 years ago

scotthavens commented 3 years ago

updated from 24 hours to 23 hours fix #55

jomey commented 3 years ago

Can we merge this?

I am currently going through the SMRF outputs and it requires an additional filter for each day to exclude the extra time step at 00:00 for the next day.

scotthavens commented 3 years ago

Forgot about this one!

jomey commented 3 years ago

Thank you!

scotthavens commented 3 years ago

FYI, this should be fixed already in the main branch.

jomey commented 3 years ago

FYI, this should be fixed already in the main branch.

Hm ... Does not look like it

New PR?

scotthavens commented 3 years ago

Hmm, guess "fixed" was a relative term.

I don't think that the daily is setup to run how it once was, I'd have to check as I was making a lot of changes to the way AWSM was ran. Off the top of my head, you should be able to run it in a daily mode but write to the same netcdf output files, bypassing the daily folders. It should also have written out to daily folders but the script may not have been fixed.

jomey commented 3 years ago

Trying to follow your train of thought.

I have daily outputs, but basically each day also has a '00:00' hour for the next day. This I attributed to this fix, where SMRF was given 25 hours. Is that correct?

Will there be a different behavior on main, no longer producing daily output files?

scotthavens commented 3 years ago

Haven't been in AWSM/SMRF world for a while... But yes, this was merged to release-0.10 which will remove the 00:00 hour from the daily SMRF files.

In main, I started with making sure the AWSM would run in the standard start/end date folder structure and the output files would be appended. This is intended to replace the daily folder and make it easier to work with the files, especially when using HRRR. However, I don't think I've finished the daily AWSM folder creation that would make it like how you and release-0.10 are running.