USDA-ARS-NWRC / inicheck

Automated handling, checking, and outputting of complicated .ini configuration files.
Other
1 stars 4 forks source link

Add a new type call DiscretionaryCriticalFilename #29

Closed micahjohnson150 closed 4 years ago

micahjohnson150 commented 5 years ago

Description

There are some cases in smrf, awsm, and snowav where criticalfilename is being used to represent files that are sort of optional but the software assumed that if its None then do nothing. This is different from any static file where developers assume is always there. This cant be solved with filename types because the default behavior which is expected by the developer would always produce a warning. This has not been an issue until recently because to-date we have been accepting None as a valid value for all items. This has ended due to a couple bugs being found and new features.

So the solution is create a type called DiscretionaryCriticalFilename. This is a filename that has the ability to be None and still valid.