search

USDA-ARS-NWRC / inicheck

Automated handling, checking, and outputting of complicated .ini configuration files.
Other
1 stars 4 forks source link

Checkers should check full entries to an item not each item in the list. #34

Closed micahjohnson150 closed 4 years ago

micahjohnson150 commented 5 years ago

Description

Currently inicheck checkers manage values as a one off item even when its a list. So if an entry is a list then we go through each item and look at the independently then go in with a checker and examine it.

This breaks down when we consider whats a list and how do we cast it. Casting to date has been a function of the checkers so how does a checker cast a single value into a list when were not done with the list yet?

The solution I think is to move the entire loop into the checker business. This will bring some clarity to whats happening and ultimately a final gate to manage the list or not list scenario.

micahjohnson150 commented 5 years ago

This will also help with testing and reduce the amount of indentation going on in the casting and checking of config files. All pluses IMO