test_variables in test_full_smrf.py doesn't assert anything

USDA-ARS-NWRC / smrf

SMRF was designed to increase the flexibility of taking measured weather data, or atmospheric models, and distributing the data across a watershed.

Other

12 stars 4 forks source link

test_variables in test_full_smrf.py doesn't assert anything #128

Closed micahjohnson150 closed 4 years ago

micahjohnson150 commented 5 years ago

Line 44 doesnt't assert anything. And then in Line 81 also doesn't assert anything so the test is always successful. GULP.

scotthavens commented 4 years ago

Tested with fresh clone and this does not pass.

micahjohnson150 commented 4 years ago

@scotthavens I wiped mine clean, cloned master, checked out develop, added the assertion statement and still passed locally. I made a new branch called testissues#128 and pushed to the repo. It also passed on TravisCI. Take a look at that branch and lets see if there is something I am missing that you have.

micahjohnson150 commented 4 years ago

Can you check out your branch and push to see if travisCI passes/fails it too?

scotthavens commented 4 years ago

This was an IPW build problem on my part. Rebuilt IPW and the tests pass.

scotthavens commented 4 years ago

@micahjohnson150 was this merged as well?