USDA-ARS-NWRC / smrf

SMRF was designed to increase the flexibility of taking measured weather data, or atmospheric models, and distributing the data across a watershed.
Other
12 stars 4 forks source link

Config file change log in application #143

Open scotthavens opened 4 years ago

scotthavens commented 4 years ago

Converting the gold config file (for the station data run tests/RME/gold) over to the new parameters brought about a few gotchas and issues. Converting the file with inicheck produced multiple errors in the new config file that required addressing.

Converting the gold config file (for the HRRR data run tests/RME/gold_hrrr)

Seem like working on the recipes will help.

micahjohnson150 commented 4 years ago

I am not surprised there are issues with the changelog stuff.

I don't quite follow the problem though. Are you saying you had to add grid_mask and grid_method in? Was vapor_pressure missing completely?

scotthavens commented 4 years ago

Sorry, probably wasn't that clear. Those were extra fields that were in each section. vapor_pressure also had the grid methods, don't know why it showed up.

cloud_factor was missing almost everything.

micahjohnson150 commented 4 years ago

The cloud factor is the most peculiar one to me. It should be there by all accounts. inicheck sees the full core config entry so I know its not a typo gone under the radar. When I ask for the recipes it inicheck sees that it uses the cloud_factor_recipe. So why is there nothing else in there....

Here is what I did to replicate. Let me know if this is different than what you did.

inicheck -m smrf -f tests/RME/gold/config.ini --change -w