search

USDA-ARS-NWRC / smrf

SMRF was designed to increase the flexibility of taking measured weather data, or atmospheric models, and distributing the data across a watershed.
Other
12 stars 4 forks source link

ImageData - First step towards central thread variable. #177

Closed jomey closed 4 years ago

jomey commented 4 years ago

This is my first hunch. Looking further at the threading logic and consolidate the structure for non- vs distributed execution could simplify a few more pieces. Work in progress.

scotthavens commented 4 years ago

The @property is probably cleaner way to do this. The thread variables are quite a mess at the moment but a lot of that won't be cleaned up until we clean up some of the distribute function calls. For example, precip requires a lot of thread variables even though not all are used. Although cleaning up precip is a whole other beast... which will probably happen once Ernesto precip rescaling is ready to be incorporated.

jomey commented 4 years ago

The failing tests are the same that are failing on the original 18_threading branch. Should we just merge this and take care of those on the original?

scotthavens commented 4 years ago

So merge your branch into 18_threading?

jomey commented 4 years ago

So merge your branch into 18_threading?

Yup, if you are OK with this approach. The target for this PR is set to that. Only need to allow merging with not passed checks somehow