search

USDA-ARS-NWRC / smrf

SMRF was designed to increase the flexibility of taking measured weather data, or atmospheric models, and distributing the data across a watershed.
Other
12 stars 4 forks source link

SRMF data loading - Class structure #201

Closed jomey closed 3 years ago

jomey commented 3 years ago

Establishing a class inheritance structure for gridded input data to ensure some consistency across them. This mainly takes care of initializing them and ensuring required attributes across them.

jomey commented 3 years ago

This is the first result of looking into excluding wind data loading from HRRR, when katana is the chosen wind model. Breaking this up into an early PR since it seems a good first point to merge.

jomey commented 3 years ago

Looks good!

One thing I'm wondering outside of this PR is test documentation. I like how you've built a lot of the tests for the class setup and rely on the full suites to test that they work. But I'm wondering if someone was to just look at that, they might not know that?

I will add some documentation for the test suite.

scotthavens commented 3 years ago

So this will never pass Travis CI as we ran out of credits, I have requested more. @jomey let me know when you're ready and I'll use the big hammer. I have tested this locally and everything passes.

jomey commented 3 years ago

So this will never pass Travis CI as we ran out of credits, I have requested more. @jomey let me know when you're ready and I'll use the big hammer. I have tested this locally and everything passes.

Any luck with more credits? Could we apply the big :hammer: to this PR?

scotthavens commented 3 years ago

🔨 No luck on credits yet, I don't expect it to be fast if we get more.