search

USDA-FSA / fsa-style

CSS Implementation of USDA's FPAC Design System
http://usda-fsa.github.io/fsa-style/
Other
11 stars 8 forks source link

Attempt to remove Bourbon #296

Closed francisrupert closed 5 years ago

francisrupert commented 5 years ago

Bourbon is fairly baked into uswds, so probably not possible. What would it take to remove? Is fsa-style even really suffering for it?

https://github.com/USDA-FSA/fsa-style/blob/9dfa41107960f1889385fee5945d1759a4b2a270/src/stylesheets/_uswds-select.scss#L9-L11

(Outcome of #293)

francisrupert commented 5 years ago

I experimented to understand the implications of removing Bourbon, as demo'd on https://github.com/USDA-FSA/fsa-style/commit/afb6bc71ac368051ab83a1e173f12fbc183e2524

General Finding: I was able to get really far, but there were just a simple lines here and there - all of which I could manually move elsewhere and call it a day. However... because it's a core dependency of uswds, we can't presume how they will or won't make use of Bourbon in potential 1.x.x updates. Thus the right call is to leave it alone.