search

USDA-FSA / fsa-style

CSS Implementation of USDA's FPAC Design System
http://usda-fsa.github.io/fsa-style/
Other
11 stars 8 forks source link

#332 Remove datepicker dependency on a script tag #333

Closed atdiff closed 5 years ago

atdiff commented 5 years ago

332. Removed the dependency on a script tag and the allowance of configuration to be passed in that way. (http://freqdec.github.io/datePicker/#setting-global-configuration-parameters) Left the original code commented for posterity. Also left the scriptFiles variable for the logic around deriving the locale.

francisrupert commented 5 years ago

@bignamehere, can you review this too? I've reviewed and tested it as thoroughly as I can.

Thanks @atdiff!

francisrupert commented 5 years ago

@bignamehere, I'm planning to approve and merge this Pull Request and then publish 2.3.2 tomorrow morning.

I've further tested this some more and feel confident in it. Feel free to test it too, though an official "Pull Request Approval" by you isn't necessary.