search

USDA-FSA / fsa-style

CSS Implementation of USDA's FPAC Design System
http://usda-fsa.github.io/fsa-style/
Other
11 stars 8 forks source link

Reflect more accurate value of aria-current #397

Closed bignamehere closed 4 years ago

bignamehere commented 4 years ago

Description

Currently, the ARIA attribute to indicate the current step in the stepped tabs component uses a value of "true". I propose using the value of "step" for this indication, as it more accurately defines the status of the component for Users with assistive technologies.

Current Proposed
aria-current="true" aria-current="step"

Additionally, consider the same for other components, e.g. Pagination.

Reference

Screenshot example

image

francisrupert commented 4 years ago

Good call. I’d initially landed on “true” as a safe value so as not to presume it is always a “step.”

I’d update it to “step” and provide docs that allow for implementer to make a judgement call on if it’s actually a “page”.

francisrupert commented 4 years ago

Extending this issue to all components with aria-current attribute, e.g. Stepped Tabs, Pagination, Content Tabs.