USDAForestService / USFS-timber-permitting

The focal point for an 18F/TTS project with the United States Forest Service on timber permitting
Other
6 stars 3 forks source link

Calculate permit cost: As a permit purchaser, I need to understand how much the wood I’d like to harvest will cost, so that I understand how much money I’ll need to make the purchase. #113

Open MelissaBraxton opened 4 years ago

MelissaBraxton commented 4 years ago

Background Allows permit purchaser to select product quantity dropdown component and to see the cost of the product/quantity combination.

Acceptance criteria

Tasks

Definition of done

MelissaBraxton commented 4 years ago

We've mocked cost as calculated on the permit data entry form. Here is the mock

carlsonem commented 4 years ago

@Dmac26 has this been started?

Dmac26 commented 4 years ago

@carlsonem - Hey Eric, I had a couple of false starts on this last week and a few other issues that came up. But, I'm firmly started today.

jstrothman commented 4 years ago

@Dmac26 It looks like this one's waiting on design review. Could you tag me here when it's on dev or staging? Thanks!

Dmac26 commented 4 years ago

@jstrothman - I will let you know! There were a few code changes that needed to be made. Those are done now and I'm just working on getting the merge done. I'll keep you posted!

jstrothman commented 3 years ago

@Dmac26 I see this is ready for review, and the validation is working. Currently, we show the minimum, but not the maximum number of cords for the forest, so it's easy to put in too many and find out the constraints after input.

Can we change the language to: **Number of cords * Cost: $5 per cord You can get between 4 - 12 cords [Input field] Total cost for firewood permit**

with an error message: 'Number of cords must be between x and y'

jstrothman commented 3 years ago

@Dmac26 Any update on this adjustment to showing the max cords and changing the error message?

Dmac26 commented 3 years ago

@jstrothman - Sorry I missed your comment from earlier. Since this has already been merged up to dev, I'd like to make a new card for this and track there if you don't mind. This should be an easy fix though. I should have a Pull Request in by tomorrow morning.

mtlaney commented 3 years ago

Calculations appear to be correct on the open forest side. We will need to verify we are sending the right amount to pay.gov