As a permit purchaser, I can get general information on harvesting firewood from a particular pilot forest before I decide to buy a permit, so that I can know whether a firewood permit is right for me.

MelissaBraxton commented 4 years ago

Background This issue describes the forest information page for firewood specifically, and covers the general design and layout of the forest-specific firewood permitting info page. We may consider creating new issues for each pilot forest having complete and accurate information for their forest once the navigating from the main page is working and we have completed the general design and layout of the firewood info page.

Acceptance criteria

[x] User can get information about firewood permitting specific to the forest they've selected

Tasks

[x] Review OF landing page
[x] Review 18F mocks and task flow
[x] Review user needs statements from firewood permitting research
[x] Mock up refinements as needed
[x] Technical review of proposed shared service approach
[x] Build page based on mocks
[x] Architecture/engineering review
[x] Validation of acceptance criteria completed
[x] Product Owner Approved
[x] Design review
[x] Code review

Definition of done

[x]  e2e tests are updated for application routing changes.
[x] e2e tests are functioning.
[x] Child routes for existing pages are working.
[x] Pull requests meet technical definition of done.
[x] Usability tested

MelissaBraxton commented 4 years ago

Here's the mock of the forest info page: https://gsa.invisionapp.com/share/R3VA86RNPWK#/screens/397192438

carlsonem commented 4 years ago

@MelissaBraxton is that mock-up ready to start the development? I don't see all the boxes checked, but appears to be a design that is ready to start with. @aQuib you might also know.

MelissaBraxton commented 4 years ago

I'll defer to @aQuib re: whether he and Mark are able to check off any of the initial tasks and/or wether this is now blocked with Mark out.

We had documented some suggested refinements based on the last round of usability testing before we paused the product: https://github.com/USDAForestService/USFS-timber-permitting/wiki/Usability-Test-1:-Online-permit-buying-flow-and-printable-load-tags but much of it is guidance around forest-specific content, once we start adding it.

aQuib commented 4 years ago

@MelissaBraxton, @carlsonem - that sounds like a good approach.

MelissaBraxton commented 4 years ago

Adding @timoballard for code review as needed.

briandavidson commented 4 years ago

@MelissaBraxton @carlsonem -- per the acceptance criteria: User can get from landing page to forest-specific page of their choice

If I understand correctly from our conversation the other day with @aQuib, the plan is to move the forest finder to the main landing page and that will allow them to get to the specific forest they choose.

User can get information about firewood permitting specific to the forest they've selected

We won't be able to see forest-specific information until the corresponding issues for adding each forest's data have been completed -- the work done so far for this issue was to setup the template page that will eventually get populated with the data from the forests we are adding.

Do we want to put this into blocked until those two things are taken care of?

MelissaBraxton commented 4 years ago

Tagging in @csstarling to weigh in here as well.

It looks like there are some tasks that have yet to be checked off here. I would leave this in in-progress, since I don't believe design is blocked. @aQuib and @Rebekah-Hernandez can maybe provide an update?

This is not ready for validation until the landing page matches the mocks that have been reviewed and approved by the PO, which I believe is the version you mentioned w/ the forest finder at the top of the current landing page.

From my perspective, the work to set up the template page should be sufficient, as long as each pilot forest is available in the forest finder and we can get from the landing page to forest template pages. Having forest specific content in the template is covered in the forest-specific issues.

I'd suggest revising the acceptance criteria to "User can get to information about firewood permitting specific to the forest they've selected"

aQuib commented 4 years ago

@MelissaBraxton @briandavidson - There isn't any design aspect that is blocking this ticket and I support changing the acceptance criteria to Melissa's recommendations.

briandavidson commented 4 years ago

@MelissaBraxton @briandavidson - There isn't any design aspect that is blocking this ticket and I support changing the acceptance criteria to Melissa's recommendations.

@aQuib the only mock that I'm aware of for this issue is this one that just shows the forest info page. I think we still need one for how the forest picker will look on the landing page.

@MelissaBraxton @carlsonem -- would it be alright if we broke out the task for moving the forest picker to the landing page into it's own issue? I feel like the work required to build the forest info page, and the work required to move the forest picker to the landing page, are substantial and distinct enough to warrant each having their own issue.

MelissaBraxton commented 4 years ago

@briandavidson - That's a great suggestion. It's fine by me!

(cc @csstarling)

aQuib commented 4 years ago

@briandavidson - There is a hifi mockup of the land page. Is this what you are asking about? The hero image for that page is located here.

briandavidson commented 4 years ago

@briandavidson - There is a hifi mockup of the land page. Is this what you are asking about? The hero image for that page is located here.

Yes, thanks @aQuib

csstarling commented 4 years ago

Hey, can someone give me permission to view the Box documents listed in the above comments. Thanks!

briandavidson commented 4 years ago

@MelissaBraxton @carlsonem since we're splitting out the task for moving the forest-picker into it's own issue do we want to move this to validation, or should we have this depend on the new one?

MelissaBraxton commented 4 years ago

Yes, I think this can move to validation, @briandavidson. Let's move the acceptance criteria on "being able to choose a forest from the landing page" to #147. cc @csstarling

briandavidson commented 4 years ago

Yes, I think this can move to validation, @briandavidson. Let's move the acceptance criteria on "being able to choose a forest from the landing page" to #147. cc @csstarling

Great, thanks for the confirmation Melissa. I'll go ahead and flesh out #147 to capture the work involved but please feel free to make adjustments to it. cc @carlsonem

csstarling commented 4 years ago

The general design and content looks good. Some more refinement will be needed later.

MelissaBraxton commented 4 years ago

Added design and code review tasks.

MelissaBraxton commented 4 years ago

@mtlaney - Can you add a link to the PR so that @mgwalker can review, please?

jstrothman commented 4 years ago

Design Review notes (some notes may apply only to Flathead):

@aQuib @Rebekah-Hernandez @mtlaney Generally looks great!

Adjustment Suggestions

Links in the Open Forest Design System are underlined so that we don't rely on color alone to convey information. This ensures that people who have color-related vision deficiencies and/or are in poor lighting conditions can still distinguish the content
In Where to Find section, "Standing dead trees may be cut unless are" -- perhaps remove "are" from this phrase, as it's awkward when reading
Under Cutting Instructions, there's a space missing in "yourfalling equipment and skills"
The How to Cut Your Firewood section has some repeated content: "Using your firewood" is there 3 times (though the 2nd time has different text than the 1st & 3rd times; "Equipment you'll need" and "What to expect" are repeated.
The "Contact us" section would be easier to copy-and-paste from (and take up less space) if line breaks were used between address lines instead of paragraph tags for each line.

Wood Burning Rate Table The wood burning rate table could use a few adjustments for design and accessibility purposes:

The text above the wood burning rate table doesn't explicitly state that higher BTU means higher efficiency / heat -- it would be helpful to explicitly explain this
Add a title to the table inside a <caption> tag, e.g. "Wood-burning heat rates"
Move the header row inside a <thead> tag so that it gets the gray background header style of the Open Forest Design System tables
In support of screen reader users, signify that the headers are for the column, i.e. <th scope="col">

jstrothman commented 4 years ago

cc @csstarling (copying you on issues where I added design review notes last week)

csstarling commented 4 years ago

@aQuib , @Rebekah-Hernandez , @mtlaney Please consider @jstrothman above comments. these changes will be helpful.

jstrothman commented 4 years ago

@csstarling Looks good! Ready to move forward.

csstarling commented 4 years ago

@aQuib i can the usability box be checked?

aQuib commented 4 years ago

@csstarling - This has been usability tested (and I just checked checkbox)

USDAForestService / USFS-timber-permitting

As a permit purchaser, I can get general information on harvesting firewood from a particular pilot forest before I decide to buy a permit, so that I can know whether a firewood permit is right for me. #121

Design Review notes (some notes may apply only to Flathead):